A tiny improvement

Hi all,

first things first: Great class! Easy to use and a fully featured example. However, some improvements could be made (in order for the example to function well and to "tighten" up the security issues related to getting pivasa images over the weg by using the provided calls).

A tiny type on the example:
file: picasaweb.class.php
line 21: delete one "p" in "disphoto.php" or rename the file

Now to security:
in file disphoto.php
line 10: remove username and password and use the following line
$uri="pwaphoto.php?albumid=$_GET[albumid]&photoid=$_GET[photoid]";

then, in file pwaphoto.php
fill in the correct username and password in PHP
line 13: use $oPwa->login("xxxxxxx", "yyyyyyy");
instead of providing a "readable" URL

This way, the credentials could still be sniffed but at least not easily read by everyone...

Cheers,

Joern

You are right, there ist not much security in the example. I wanted to hold the example as simple as possible. The example is intended to show how it works rather than to use as an application.

To improve the security I suggest to put the object in a session variable or work with ajax using post variables.

Thomas